Remove OnBeforeNavigation callback in renderer process (#403)

cztomczak · May 24, 2018 · 44a74ad · 44a74ad
1 parent 9398d68
commit 44a74ad
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 19 deletions.
diff --git a/src/cef_v59..v66_changes.txt b/src/cef_v59..v66_changes.txt
@@ -20,11 +20,12 @@ BREAKAGE (needs updating Migration Guide doc)
 - + OnPrintJob new param
 - + OnPrintReset new param
 
-cef_render_process_handler.h
-- Remove OnBeforeNavigation in subprocess/cefpython_app.h and .cpp files
++ cef_render_process_handler.h
+- + Remove OnBeforeNavigation in subprocess/cefpython_app.h and .cpp files
 
 cef_request_handler.h
 - OnBeforeBrowse: new param 'user_gesture'
+- update Migration Guide
 
 internal/cef_linux.h
 internal/cef_types_linux.h
@@ -44,10 +45,11 @@ internal/cef_types_win.h
 internal/cef_types.h
 - cef_settings_t:
   - javascript_open_windows option removed (keep a dummy for BC)
+    - update Migration Guide
 - cef_thread_id_t:
   - TID_DB removed (update Migration Guide)
-  - TID_PROCESS_LAUNCHER removed
-  - TID_CACHE removed
+  - TID_PROCESS_LAUNCHER removed (update Migration Guide)
+  - TID_CACHE removed (update Migration Guide)
 
 
 NEW FEATURES

diff --git a/src/subprocess/cefpython_app.cpp b/src/subprocess/cefpython_app.cpp
@@ -259,14 +259,6 @@ void CefPythonApp::OnBrowserDestroyed(CefRefPtr<CefBrowser> browser) {
     RemoveJavascriptBindings(browser);
 }
 
-bool CefPythonApp::OnBeforeNavigation(CefRefPtr<CefBrowser> browser,
-                                      CefRefPtr<CefFrame> frame,
-                                      CefRefPtr<CefRequest> request,
-                                      cef_navigation_type_t navigation_type,
-                                      bool is_redirect) {
-    return false;
-}
-
 void CefPythonApp::OnContextCreated(CefRefPtr<CefBrowser> browser,
                                     CefRefPtr<CefFrame> frame,
                                     CefRefPtr<CefV8Context> context) {

diff --git a/src/subprocess/cefpython_app.h b/src/subprocess/cefpython_app.h
@@ -74,13 +74,6 @@ class CefPythonApp :
   void OnBrowserDestroyed(CefRefPtr<CefBrowser> browser)
         override;
 
-  bool OnBeforeNavigation(CefRefPtr<CefBrowser> browser,
-                                  CefRefPtr<CefFrame> frame,
-                                  CefRefPtr<CefRequest> request,
-                                  cef_navigation_type_t navigation_type,
-                                  bool is_redirect)
-        override;
-
   void OnContextCreated(CefRefPtr<CefBrowser> browser,
                                 CefRefPtr<CefFrame> frame,
                                 CefRefPtr<CefV8Context> context)