Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatureRequest: Add build artifacts for CI/CD pipeline #369

Closed
1 of 2 tasks
kenibrewer opened this issue Jan 27, 2024 · 0 comments · Fixed by #373
Closed
1 of 2 tasks

FeatureRequest: Add build artifacts for CI/CD pipeline #369

kenibrewer opened this issue Jan 27, 2024 · 0 comments · Fixed by #373
Labels
enhancement New feature or request

Comments

@kenibrewer
Copy link
Member

Feature type

  • Add new functionality

  • Change existing functionality

General description of the proposed functionality

Add additional steps to Github Actions workflow that will build a properly-versioned code artifact using poetry build instead of the "version-less" copy of the source code currently generated. These code artifacts can be used in the following ways:

  1. Include new build artifacts in the Github release alongside the existing source code tarball.
  2. Drops the need for poetry-dynamic-versioning and a full git history in:
  • Docker images
  • Dependent Github actions workflows.

Feature example

- step: build wheel/sdist
  run: poetry build
- step: upload-artifact 
  with: https://github.com/actions/upload-artifact

- step: build docker image
  with: download-artifact
- step: unpack artifact
- step: build docker image

Alternative Solutions

No response

Additional information

We should also add a section to pyproject.toml that includes files we want/need in our build artifact such as the tests directory.

See: https://python-poetry.org/docs/pyproject/#include-and-exclude

@kenibrewer kenibrewer added the enhancement New feature or request label Jan 27, 2024
@kenibrewer kenibrewer changed the title FeatureRequest: Add build artifacts for merges to main branch FeatureRequest: Add build artifacts for CI/CD pipeline Jan 27, 2024
kenibrewer added a commit to kenibrewer/pycytominer that referenced this issue Feb 21, 2024
This adds a versioned code artifact to the ci pipeline that can be used during other actions and in Github releases.

Closes cytomining#369
kenibrewer added a commit to kenibrewer/pycytominer that referenced this issue Feb 21, 2024
This adds a versioned code artifact to the ci pipeline that can be used during other actions and in Github releases.

Closes cytomining#369
Co-authored-by: Dave Bunten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant