Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add join concatenation parameter distinction #181

Merged
merged 6 commits into from
Oct 24, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Mar 29, 2024

Description

This PR enables "joined" CytoTable output which is not concatenated, reducing the amount of processing involved if a user would like to leverage Parquet datasets (multi-file Parquet tables).

Thank you for any thoughts or feedback you may have!

CC @MikeLippincott

Closes #178

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@d33bs
Copy link
Member Author

d33bs commented Oct 24, 2024

Thanks @gwaybio ! Merging this in.

@d33bs d33bs merged commit 4e8c57f into cytomining:main Oct 24, 2024
12 checks passed
@d33bs d33bs deleted the join-concat-options branch October 24, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distinguish between joined and unjoined concatenation
2 participants