Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from dev-dependencies to poetry group specification #146

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Jan 16, 2024

Description

This PR moves the pyproject.toml file to use Poetry's "group dependency" specification (see "A note about defining a dev dependencies group"). The existing dev-dependencies table in the pyproject.toml file is synonymous with the dev group, and this change updates the table name to reflect updated Poetry nomenclature + documentation.

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @kenibrewer might have better feedback.

@d33bs
Copy link
Member Author

d33bs commented Jan 18, 2024

Thank you @gwaybio for the review! Merging this in. @kenibrewer please don't hesitate to let me know if we may have missed something here.

@d33bs d33bs merged commit d5f6b46 into cytomining:main Jan 18, 2024
7 checks passed
@d33bs d33bs deleted the poetry-move-to-dev-group branch January 18, 2024 16:53
@kenibrewer
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants