Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define and demonstrate data transform types within documentation #142

Merged
merged 10 commits into from
Jan 13, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Jan 10, 2024

Description

This PR adds further clarification surrounding the use of data transformation terminology within CytoTable to resolve #13 . While these were developed, I noticed that HTML tables required CSS styling, resulting in the CSS modifications.

Thanks for any thoughts or feedback you may have!

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after some minor clarification updates

docs/source/overview.md Outdated Show resolved Hide resolved
docs/source/overview.md Outdated Show resolved Hide resolved
docs/source/overview.md Outdated Show resolved Hide resolved
docs/source/overview.md Outdated Show resolved Hide resolved
docs/source/overview.md Outdated Show resolved Hide resolved
@d33bs
Copy link
Member Author

d33bs commented Jan 12, 2024

Thanks @gwaybio for your review! Made some updates based on your comments and going to merge.

@d33bs d33bs merged commit 7893e8e into cytomining:main Jan 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide concept documentation to outline data transform types
2 participants