Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced a method, SetAlternateBaseURL(), enabling the selection of… #43

Merged
merged 1 commit into from
Apr 15, 2023

Conversation

allanpk716
Copy link
Contributor

Introduced a method, SetAlternateBaseURL(), enabling the selection of alternative API base URLs to accommodate varying network conditions across countries.

Description

In my country, accessing api.themoviedb.org is restricted in many regions, while api.tmdb.org remains accessible. SetAlternateBaseURL() can be called after Init() to toggle the requested API URL.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

All test cases from the original project have passed. Utilizing the new SwitchBaseURL(TMDB) function yields accurate results when querying data as well.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

… alternative API base URLs to accommodate varying network conditions across countries.
Copy link
Owner

@cyruzin cyruzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cyruzin cyruzin merged commit 45ea5e2 into cyruzin:master Apr 15, 2023
@cyruzin
Copy link
Owner

cyruzin commented Apr 15, 2023

@cyruzin cyruzin added the enhancement New feature or request label Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants