Support for RabbitMq versions 3.9 and 3.10 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrilgdn
requested changes
Aug 26, 2022
.travis.yml
Outdated
| @@ -13,6 +13,8 @@ env: | |||
| - RABBITMQ_USERNAME="guest" | |||
| - RABBITMQ_PASSWORD="guest" | |||
| jobs: | |||
| - RABBITMQ_VERSION=3.10 | |||
There was a problem hiding this comment.
Actually Travis is not used anymore, I should remove this file 🤦♂️
I removed it on master so you can merge it in your branch
Co-authored-by: Cyril Gaudin <[email protected]>
# Conflicts: # .travis.yml
|
Requested changes pushed, please take a look again. |
|
Hello, any news on this ? |
|
Hello @cyrilgdn Would you have some time to review this PR maybe? Thanks in advance, |
cyrilgdn
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran acceptance tests locally for both 3.9 and 3.10 and they passed.
Versions 3.7 and 3.8 of rabbitmq are officially out of support : https://www.rabbitmq.com/versions.html#out-of-support
can we remove them from the list of officially supported versions for this provider ?