-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for assuming an AWS IAM role from the provider. #486
Conversation
This commit proposes a solution for cyrilgdn#263
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on that 💪
A few minor comments/questions otherwise 👍
Change RoleSessionName to be more descriptive. Co-authored-by: Cyril Gaudin <[email protected]>
More descriptive wrapper for the error message. Co-authored-by: Cyril Gaudin <[email protected]>
More descriptive wrapper for the error message. Co-authored-by: Cyril Gaudin <[email protected]>
Thanks for the review. Do let me know if any further updates are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
Hi @cyrilgdn , I noticed that some changes have been merged, but as far as I can tell, they haven’t been released yet (based https://registry.terraform.io/providers/cyrilgdn/postgresql/latest/doc ). Could you let me know approximately when these changes are expected to be released? Thank you! |
@zizzencs @dkuznetsov01 This has just been release in https://github.com/cyrilgdn/terraform-provider-postgresql/releases/tag/v1.25.0 |
This pull request proposes a solution for #263