Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for assuming an AWS IAM role from the provider. #486

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

zizzencs
Copy link
Contributor

This pull request proposes a solution for #263

Copy link
Owner

@cyrilgdn cyrilgdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on that 💪

A few minor comments/questions otherwise 👍

postgresql/provider.go Show resolved Hide resolved
postgresql/provider.go Outdated Show resolved Hide resolved
postgresql/provider.go Outdated Show resolved Hide resolved
postgresql/provider.go Outdated Show resolved Hide resolved
zizzencs and others added 3 commits November 4, 2024 18:44
Change RoleSessionName to be more descriptive.

Co-authored-by: Cyril Gaudin <[email protected]>
More descriptive wrapper for the error message.

Co-authored-by: Cyril Gaudin <[email protected]>
More descriptive wrapper for the error message.

Co-authored-by: Cyril Gaudin <[email protected]>
@zizzencs
Copy link
Contributor Author

zizzencs commented Nov 4, 2024

Thanks for the review. Do let me know if any further updates are needed.

@zizzencs zizzencs requested a review from cyrilgdn November 4, 2024 18:08
postgresql/provider.go Outdated Show resolved Hide resolved
Copy link
Owner

@cyrilgdn cyrilgdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@cyrilgdn cyrilgdn merged commit 95d8d6d into cyrilgdn:main Nov 7, 2024
6 checks passed
@dkuznetsov01
Copy link

Hi @cyrilgdn ,

I noticed that some changes have been merged, but as far as I can tell, they haven’t been released yet (based https://registry.terraform.io/providers/cyrilgdn/postgresql/latest/doc ).

Could you let me know approximately when these changes are expected to be released?

Thank you!

@cyrilgdn
Copy link
Owner

cyrilgdn commented Dec 5, 2024

@zizzencs @dkuznetsov01 This has just been release in https://github.com/cyrilgdn/terraform-provider-postgresql/releases/tag/v1.25.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants