Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update glow information #71

Merged
merged 8 commits into from
Dec 9, 2024
Merged

Conversation

agodet
Copy link

@agodet agodet commented Dec 8, 2024

  • switch lock are working now for glow and onyx
  • target_temperature_high improve (error between high and low parameter)
  • heatzy_to_ha_state set to correct mapping
  • new feature : display 7°C to target temperature when preset mode is away

@agodet
Copy link
Author

agodet commented Dec 8, 2024

I don't understand how it was working before ? did someone with glow or onyx devices has something which works correctly ?

@cyr-ius cyr-ius merged commit d284958 into cyr-ius:master Dec 9, 2024
4 of 6 checks passed
@cyr-ius
Copy link
Owner

cyr-ius commented Dec 9, 2024

@agodet : I validated the pull request but several things raise questions that do not correspond to the documentation:

https://docs.google.com/document/d/17QL1iu4F4TMr6ihN-Hz6DFNRzhkZpDyIQ_NXdUzVzME/edit?tab=t.0

You put the following values ​​on heatzy_to_ha_state:
0: PRESET_COMFORT,
1: PRESET_ECO,
2: PRESET_AWAY,
3: PRESET_COMFORT_1,
4: PRESET_COMFORT_2,
5: PRESET_NONE,
but the documentation gives the following values:
0: PRESET_COMFORT,
1: PRESET_ECO,
2: PRESET_AWAY,
3: PRESET_NONE,
4: PRESET_COMFORT_1,
5: PRESET_COMFORT_2,
The shutdown is in 3 and not in 5

In the preset mode, you do not select the PRESET_COMFORT_1 and PRESET_COMFORT_2 modes while the documentation indicates that they exist.

You replaced the Automatic mode which is the mode with programmer by the Boost mode while the documentation specifies that this mode exists

Are you sure of all your modifications?

@agodet
Copy link
Author

agodet commented Dec 9, 2024

i'm glad to know there is a documentation...
You're right about the given values coming from the documentation, i'm wrong about none, comfort_1, comfort2
I didn't see PRESET_COMFORT_1 and PRESET_COMFORT_2 inside the heatzy app, maybe it is used when you use your radiator with a pilot wire.
for derog_mode, unfortunately, that's not what i see when i play with heatzy app and rectrieve data information by calling apis. But maybe i'm wrong, i will do other test now i have the documentation.
Thank you

@cyr-ius
Copy link
Owner

cyr-ius commented Dec 9, 2024

i'm glad to know there is a documentation... You're right about the given values coming from the documentation, i'm wrong about none, comfort_1, comfort2 I didn't see PRESET_COMFORT_1 and PRESET_COMFORT_2 inside the heatzy app, maybe it is used when you use your radiator with a pilot wire. for derog_mode, unfortunately, that's not what i see when i play with heatzy app and rectrieve data information by calling apis. But maybe i'm wrong, i will do other test now i have the documentation. Thank you

I built version 6.4.1-beta2 which I think is the right configuration. Tell me what you think? Send a PR if it is not good. For info, I fixed the switch.py ​​file because it did not work with other heatzy 's device versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants