Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updates related to release process #41

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

chrisbreiding
Copy link

PR Checklist:

  • I have run npm test locally and all tests are passing.
  • [N/A] I have added/updated tests for any new behavior.
  • [N/A] If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

Some updates related to how this package is released.

  • Added a note to the contributing doc
  • Removed release.sh since that was related to the old way of releasing
  • Change the committed package.json version to 0.0.0-development. This is standard when using semantic-release, since it does not commit the new version back to the repo when publishing it. This way the committed version isn't wrong and there's no need to manually update the version when there is a new release.

@@ -68,6 +68,8 @@ There are a few basic ground-rules for contributors:

Declaring formal releases remains the prerogative of the project maintainer.

This package uses semantic versioning and [semantic-release](https://github.com/semantic-release/semantic-release) to auto-publish releases to npm upon merge into the master branch.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😅

@MikeMcC399
Copy link

@chrisbreiding

Thanks for cleaning this up! The published package is fine. I just noticed the wrong version logged in https://github.com/cypress-io/request/actions/runs/5797590779/job/15713444906 for the v3.0.0 release, which had me scratching my head! 🙂

@chrisbreiding chrisbreiding merged commit 99338c8 into master Aug 8, 2023
@cypress-app-bot
Copy link

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants