docs: remove deprecated set-output from example #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct Robust custom build id example in README
mjhenkes
approved these changes
Mar 6, 2023
mschile
approved these changes
Mar 6, 2023
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the README example Robust custom build id which contains code
run: echo "::set-output name=value::sha-$GITHUB_SHA-time-$(date +"%s")"that GitHub has deprecated. GitHub Actions: Deprecating save-state and set-output commands states "We are monitoring telemetry for the usage of these commands and plan to fully disable them on 31st May 2023".
I already changed the workflow example-custom-ci-build-id through PR #675 in December 2022 and at the time it was overlooked that the same problem was also contained in the corresponding text version of the example.
The replacement line of code is:
echo "value=sha-$GITHUB_SHA-time-$(date +"%s")" >> $GITHUB_OUTPUTexactly as used in
github-action/.github/workflows/example-custom-ci-build-id.yml
Line 36 in 9e53751