Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make README bookmark internal links relative #1312

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

MikeMcC399
Copy link
Collaborator

Issue

Links in the README > Usage section, which refer to bookmarks in the same document, are using absolute URLs instead of relative ones.

This can cause the wrong information to be displayed when the README is accessed in a branch which is not the default master branch.

An example is https://github.com/cypress-io/github-action#custom-install-command

Change

Convert absolute URLs to relative ones in the README.md document, for links which refer to bookmarks in the README document itself.

For example, reduce

https://github.com/cypress-io/github-action#custom-install-command

to

#custom-install-command

Verification

npm ci
npx markdown-link-check README.md

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 added the documentation Improvements or additions to documentation label Nov 16, 2024
@MikeMcC399 MikeMcC399 self-assigned this Nov 16, 2024
@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review November 16, 2024 16:45
@mschile mschile merged commit 1f750ad into cypress-io:master Nov 17, 2024
77 checks passed
@MikeMcC399 MikeMcC399 deleted the docs/README-internal-links branch November 17, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants