Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove markdown-link-check configuration #1300

Conversation

MikeMcC399
Copy link
Collaborator

Issue

markdown-link-check now runs successfully without the configuration file md-linkcheck.json.

md-linkcheck.json was added because automated markdown link checks to the github.com domain were returning HTTP 403 forbidden. This problem is no longer occurring and so a workaround is no longer necessary.

Change

Remove the file md-linkcheck.json and the reference to it in the script

"check:markdown": "find *.md docs/*.md -print0 | xargs -0 -n1 markdown-link-check -c md-linkcheck.json",

Use instead default settings.

Verification

npm ci
npm run check:markdown

Confirm all link checks are successful.

@MikeMcC399 MikeMcC399 added type: enhancement New feature or request ci labels Nov 7, 2024
@MikeMcC399 MikeMcC399 self-assigned this Nov 7, 2024
@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 marked this pull request as ready for review November 7, 2024 09:58
@jennifer-shehane jennifer-shehane merged commit f7686e1 into cypress-io:master Nov 7, 2024
77 checks passed
@MikeMcC399 MikeMcC399 deleted the remove/markdown-link-check-config branch November 7, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants