Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove code.visualstudio.com from markdown-link-check #1282

Closed

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Oct 18, 2024

Issue

markdown-link-check has started to fail with HTTP 403 Forbidden checking the hyperlink https://code.visualstudio.com/
located in docs/MAINTENANCE.md.

FILE: docs/MAINTENANCE.md
  [✓] ../examples
  [✓] https://docs.cypress.io/guides/references/configuration
  [✓] https://github.com/cypress-io/github-action
  [✓] https://www.npmjs.com/
  [✓] https://pnpm.io/
  [✓] https://classic.yarnpkg.com/
  [✓] https://yarnpkg.com/
  [✓] https://github.com/cypress-io/github-action/tree/v5/examples/v9
  [✓] https://github.com/cypress-io/github-action/tree/v5/
  [✓] https://ubuntu.com/
  [✓] https://www.apple.com/macos/
  [✓] https://nodejs.org/en/
  [✓] ../CONTRIBUTING.md#requirements
  [✓] https://git-scm.com/
  [✓] https://nodejs.org/
  [✖] https://code.visualstudio.com/
  [✓] https://docs.cypress.io/guides/references/changelog
  [✓] ../.github/workflows/example-install-only.yml

  18 links checked.

  ERROR: 1 dead links found!
  [✖] https://code.visualstudio.com/ → Status: 403

Change

Use markdown-link-check > Disable comments to disable link checking of https://code.visualstudio.com/ in docs/MAINTENANCE.md > Requirements.

Verification

Execute the following locally

npx markdown-link-check -c md-linkcheck.json docs/MAINTENANCE.md

and confirm 17 links checked. successfully.

Execute

npm run check:markdown

and confirm that all links in all checked files are successfully checked.

@MikeMcC399 MikeMcC399 added bug Something isn't working documentation Improvements or additions to documentation labels Oct 18, 2024
@MikeMcC399 MikeMcC399 self-assigned this Oct 18, 2024
@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 marked this pull request as ready for review October 18, 2024 06:30
@MikeMcC399 MikeMcC399 removed the request for review from jennifer-shehane October 19, 2024 06:29
@MikeMcC399
Copy link
Collaborator Author

Issue currently not reproducible. Closing as currently not necessary.

@MikeMcC399 MikeMcC399 closed this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants