ci: remove microsoft windows from markdown-link-check #1057
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Since last week
npm run check:markdown
has been sporadically failing when checking the link[Microsoft Windows](https://www.microsoft.com/windows/)
to https://www.microsoft.com/windows/ in the documentdocs/MAINTENANCE.md.
This is the portion of the check log showing the failure:
When accessed manually in a browser (instead of automatically through the npm module markdown-link-check) the browser correctly displays a localized version of the page.
If the link is checked by Cypress with a cy.visit(
https://www.microsoft.com/windows/
) the page is displayed, however there is a marked delay of several seconds.In similar situations where the issue has been sporadic and the failing only occurs when checking the link with
markdown-link-check
, the reason behind the failure has been increased network security, for instance as protection against Denial of Service attacks.Change
Using Disable comments
<!-- markdown-link-check-disable -->
and<!-- markdown-link-check-enable -->
the link https://www.microsoft.com/windows/ in docs/MAINTENANCE.md is disabled from
markdown-link-check
-ing.Verification
Execute the following locally
and confirm
19 links checked.
successfully.Execute
and confirm that all links in all checked files are successfully checked.