Skip to content

Commit

Permalink
wait-on example changes for react-scripts and vite server under Node.…
Browse files Browse the repository at this point in the history
…js 18 (#803)
  • Loading branch information
MikeMcC399 authored Feb 27, 2023
1 parent 14abd43 commit 63a7518
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/example-wait-on.yml
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ jobs:
with:
working-directory: examples/v9/react-scripts
start: npm start
wait-on: 'http://localhost:3000'
wait-on: 'http://127.0.0.1:3000'

wait-using-custom-command-v9:
runs-on: ubuntu-22.04
Expand All @@ -157,7 +157,7 @@ jobs:
working-directory: examples/v9/react-scripts
start: npm start
# let's use wait-on NPM package to check the URL
wait-on: 'npx wait-on --timeout 5000 http://localhost:3000'
wait-on: 'npx wait-on --timeout 5000 http://127.0.0.1:3000'

ping-cli-v9:
runs-on: ubuntu-22.04
Expand All @@ -178,7 +178,7 @@ jobs:
uses: ./
with:
working-directory: examples/v9/wait-on-vite
start: npm run dev
start: npx vite --host
wait-on: 'http://localhost:5173'

# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Cypress v10 and higher ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ #
Expand Down Expand Up @@ -317,7 +317,7 @@ jobs:
with:
working-directory: examples/react-scripts
start: npm start
wait-on: 'http://localhost:3000'
wait-on: 'http://127.0.0.1:3000'

wait-using-custom-command:
runs-on: ubuntu-22.04
Expand All @@ -330,7 +330,7 @@ jobs:
working-directory: examples/react-scripts
start: npm start
# let's use wait-on NPM package to check the URL
wait-on: 'npx wait-on --timeout 5000 http://localhost:3000'
wait-on: 'npx wait-on --timeout 5000 http://127.0.0.1:3000'

ping-cli:
runs-on: ubuntu-22.04
Expand All @@ -351,5 +351,5 @@ jobs:
uses: ./
with:
working-directory: examples/wait-on-vite
start: npm run dev
start: npx vite --host
wait-on: 'http://localhost:5173'

0 comments on commit 63a7518

Please sign in to comment.