Skip to content

Commit

Permalink
feat(deps): remove node.js 16 (#1021)
Browse files Browse the repository at this point in the history
  • Loading branch information
MikeMcC399 authored Sep 7, 2023
1 parent 74346c0 commit 59810eb
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/example-node-versions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [16, 18, 20]
node: [18, 20]
name: Cypress E2E on Node v${{ matrix.node }}
steps:
- name: Setup Node
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ See [Releases](https://github.com/cypress-io/github-action/releases) for full de

| Version | Changes |
| ------- | ------------------------------------------------------------------------------------------------------------------------------------ |
| v6.5.0 | Examples remove Node.js 16. End of support for Node.js 16. |
| v6.4.0 | Action adds PR number and URL if available when recording |
| v6.3.0 | v6 is recommended action version |
| v6.2.0 | Examples updated to Cypress 13 |
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ This information is for Cypress.io Members or Collaborators who merge pull reque
```text
fix: upgrade dependency X
BREAKING CHANGE: requires minimum Node.js 16 to run
BREAKING CHANGE: requires minimum Node.js 18 to run
```
1. New versions of this action will be released automatically by the CI when merged to the `master` branch, see [.github/workflows/main.yml](.github/workflows/main.yml). This will create a new [GitHub release](https://github.com/cypress-io/github-action/releases) and will update the current highest branch from the series `v5`, `v6`, ... etc. Thus specifying `uses: cypress-io/github-action@v6` (or higher version if available) selects the new version automatically. This **will not** push the latest release to GitHub Marketplace.
Expand Down
9 changes: 4 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ jobs:
# let's make sure our "app" works on several versions of Node
strategy:
matrix:
node: [16, 18, 20]
node: [18, 20]
name: E2E on Node v${{ matrix.node }}
steps:
- name: Setup Node
Expand Down Expand Up @@ -1133,7 +1133,7 @@ jobs:
# let's make sure our "app" works on several versions of Node
strategy:
matrix:
node: [16, 18, 20]
node: [18, 20]
name: E2E on Node v${{ matrix.node }}
steps:
- name: Setup Node
Expand Down Expand Up @@ -1167,7 +1167,7 @@ jobs:
runs-on: ubuntu-22.04
strategy:
matrix:
node: [16, 18, 20]
node: [18, 20]
name: E2E on Node v${{ matrix.node }}
steps:
- uses: actions/setup-node@v3
Expand Down Expand Up @@ -1509,7 +1509,6 @@ If no related PR is detected, `CYPRESS_PULL_REQUEST_ID` and `CYPRESS_PULL_REQUES

Node.js is required to run this action. The recommended version `v6` supports:

- **Node.js** 16.x
- **Node.js** 18.x
- **Node.js** 20.x and above

Expand All @@ -1521,7 +1520,7 @@ and is generally aligned with [Node.js's release schedule](https://github.com/no

[![Node versions example](https://github.com/cypress-io/github-action/workflows/example-node-versions/badge.svg?branch=master)](.github/workflows/example-node-versions.yml)

Cypress itself runs with a fixed Node.js version specified by the [runs.using](https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runs-for-javascript-actions) parameter of [action.yml](action.yml). `github-action@v5` uses `node16` and `github-action@v6` uses `node20`.
Cypress itself runs with a fixed Node.js version specified by the [runs.using](https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runs-for-javascript-actions) parameter of [action.yml](action.yml). `github-action@v6` uses `node20`.

## Changelog

Expand Down

0 comments on commit 59810eb

Please sign in to comment.