-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webpack-preprocessor): Allow specifying typescript path #9312
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that this fixes the original issue.
I thought this might have fixed some other weird ts issues:
- 5.4.0 Regression: TypeError: TsconfigPaths.loadConfig if not a function #9326 This issue now throws
TypeError: webpack is not a function
which I think is the error it should have been initially throwing, meaning it's a duplicate of 5.2.0 Regression: "TypeError: webpack is not a function" when baseUrl present in tsconfig.json #9145 afterall.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
// disable any overrides if | ||
// we've explictly turned off sourcemaps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dang it, how else am i supposed to read comments in my 40x12 terminal 😠
Closes TS error: Option 'sourceMap' cannot be specified with option 'inlineSourceMap' #8477
Addresses TR-450
Addresses TR-398
User facing changelog
typescript
option.Additional details
When we run the default preprocessor and require typescript, it ends up requiring cypress's own version of typescript and not the user's. This prevents us from monkey-patching the correct version of typescript for source maps compatibility.
We already search out the path to the user's typescript and pass it to the preprocessor. This utilizes that path to require typescript.
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?