fix: Register and run default preprocessor in child process #8826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
flotwig
previously approved these changes
Oct 13, 2020
Comment on lines
+19
to
+28
| const deferred = () => { | ||
| let reject | ||
| let resolve | ||
| const promise = new Promise((_resolve, _reject) => { | ||
| resolve = _resolve | ||
| reject = _reject | ||
| }) | ||
|
|
||
| return { promise, resolve, reject } | ||
| } |
There was a problem hiding this comment.
could also use Bluebird.defer, it's deprecated but i won't tell 🤫
|
This PR introduced a new issue: #8864 |
|
This PR introduced this new issue: #9145 |
|
This PR introduced a new issue: #14587 |
|
This PR also introduced #9326 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Additional details
We run user-registered file preprocessors in the plugins child process, but when the user hasn't registered their own prepocessor, we register the default preprocessor in the main Cypress process. This causes issues with preprocessor-related plugins like Istanbul that use
process.execPathto execute code becauseprocess.execPathis the Cypress binary in the main process and notnode.This fixes that by always registering and running the preprocessor in the child process, even our own default preprocessor.
Also, we used to not create the plugins child process if the user didn't have a plugins file. Now we always create it since it is necessary for running the default preprocessor.
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?