fix: Resolve tsconfig.json for plugins file from the plugins directory #8377
Conversation
was erroneously passing because it wasn't written correctly
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
- no longer register ts-node it in the parent process, only in the child process - DRYed up resolving typescript path - added test for not registering ts-node more than once
There was a problem hiding this comment.
The example from the original issue still fails within this PR. It is a different error however, so just want to double check if this is a separate issue. #8359 (comment)
|
@jennifer-shehane That error occurs because Node doesn't support the import syntax in |
chrisbreiding
changed the title
"esModuleInterop": truein cypress/tsconfig.json? #8359User facing changelog
tsconfig.jsonfor TypeScript projects starting from thepluginsdirectoryAdditional details
ts-noderesolves thetsconfig.jsonstarting from the current working directory (cwd) by default. This means usingcypress/tsconfig.jsonwon't work to specify TypeScript config for Cypress.In reality, this only affected a couple options in
tsconfig.jsonbecause only a couple options (e.g. "esModuleInterop", "downlevelIteration") affect the runtime. Any non-runtime options would take affect in a user's IDE because it would resolve thetsconfig.jsonstarting from the directory of the opened file.This PR changes it so
ts-nodewill now start looking for thetsconfig.jsonfrom the plugins directory. That iscypress/pluginsby default or thedirnameof the plugins file path if a custom one is provided. For example, if the "pluginsFile" is set to<project root>/some/other/path/to/plugins.js, it will start looking in<project root>/some/other/path/to.How has the user experience changed?
Users will now see runtime options in
cypress/tsconfig.jsontake effect, whereas before they were ignored.PR Tasks