Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix desktop gui specs not being watched for file changes #5934

Merged
merged 2 commits into from
Dec 12, 2019
Merged

fix desktop gui specs not being watched for file changes #5934

merged 2 commits into from
Dec 12, 2019

Conversation

brian-mann
Copy link
Member

@brian-mann brian-mann commented Dec 11, 2019 •
edited by flotwig
Loading

User facing changelog

  • Fixed a bug where the specs list in interactive mode would not refresh when files are changed on disk.

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 11, 2019

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@brian-mann
Copy link
Member Author

@flotwig can you do a correct PR template and write tests for this thing? thx <3

@cypress
Copy link

cypress bot commented Dec 11, 2019 •
edited
Loading


Test summary

3589 • 0 • 44 • 0

Run details
Project cypress
Status Passed
Commit 9971c3b
Started Dec 12, 2019 8:13 PM
Ended Dec 12, 2019 8:18 PM
Duration 04:51 💡
OS Linux Debian - 9.8
Browser Multiple

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig self-assigned this Dec 11, 2019
@flotwig flotwig merged commit 6e9e6ab into develop Dec 12, 2019
@cypress-bot cypress-bot bot mentioned this pull request Dec 12, 2019
Closed
brian-mann
brian-mann commented Dec 12, 2019
View reviewed changes
packages/server/test/unit/open_project_spec.js
expect(openProject.specsWatcher).to.exist
openProject.stopSpecsWatcher()
expect(openProject.specsWatcher).to.be.null
openProject.getSpecChanges()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is missing a return :-(

@flotwig flotwig deleted the issue-5933 branch January 24, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flotwig flotwig flotwig approved these changes

Assignees

@flotwig flotwig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Desktop GUI specs are not updating when they're changed due to regression with file watching
2 participants
@brian-mann @flotwig