Fix CDP cookie matching algorithm

[flotwig]

• Closes Cypress incorrectly validates domain of cookies in 3.5.0 #5656

User facing changelog

Fixed a bug where cy.getCookie would incorrectly filter cookies by their domain, leading to unexpected results.

Additional details

• previously, we were using tough.cookieMatch to filter cookies:

  cypress/packages/server/lib/browsers/cdp_automation.ts

  Lines 23 to 37 in d56c551

  	const cookieMatches = (cookie: CyCookie, data) => {
  	if (data.domain && !tough.domainMatch(cookie.domain, data.domain)) {
  	return false
  	}
  	if (data.path && !tough.pathMatch(cookie.path, data.path)) {
  	return false
  	}
  	if (data.name && data.name !== cookie.name) {
  	return false
  	}
  	return true
  	}

• however, this is incorrect
  • Cypress was designed around the internal 'cookie filter' having the same structure as the filter for WebExtensions cookies.getAll: https://developer.chrome.com/extensions/cookies#method-getAll
  • the WebExtensions filter uses domain like this: "Restricts the retrieved cookies to those whose domains match or are subdomains of this one."
  • we were using tough.domainMatch, which matches like an actual browser, instead

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• Has the original issue been tagged with a release in ZenHub?

[cypress-bot]

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

• Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
• Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

• The feature/bugfix is self-documenting from within the product.
• The change provides the end user with a way to fix their problem (no dead ends).

Functionality

• The code works and performs its intended function with the correct logic.
• Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
• The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

• The code is readable (too many nested 'if's are a bad sign).
• Names used for variables, methods, etc, clearly describe their function.
• The code is easy to understood and there are relevant comments explaining.
• New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
• There are comments containing link(s) to the addressed issue (in tests and code).

Quality

• The change does not reimplement code.
• There's not a module from the ecosystem that should be used instead.
• There is no redundant or duplicate code.
• There are no irrelevant comments left in the code.
• Tests are testing the code’s intended functionality in the best way possible.

Internal

• The original issue has been tagged with a release in ZenHub.

[cypress]

---

Test summary

3517 • 0 • 45 • 0

---

Run details

Project	cypress
Status	Passed
Commit	bf0f50a
Started	Dec 4, 2019 10:47 PM
Ended	Dec 4, 2019 10:51 PM
Duration	04:28 💡
OS	Linux Debian - 9.8
Browser	Multiple

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[brian-mann]

why not import the chrome types at the top vs putting them in the compilerOptions? I feel like this comes out of nowhere

[flotwig]

if i do import 'chrome', build fails

if i do import chrome from 'chrome', it says 'chrome' is not a module

i can dig into why import 'chrome' makes the build fail if you'd like, i'm not sure this is the best way either

[brian-mann]

ask @tgriesser in #typescript channel

[brian-mann]

nvm he's on his way to the airport - @tgriesser or @thlorenz can you explain why this is necessary whenever you have time?