Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

call setTimeout with the right global scope to prevent 'this' from being undefined #5709

Merged
merged 1 commit into from
Nov 15, 2019
Merged

call setTimeout with the right global scope to prevent 'this' from being undefined #5709

merged 1 commit into from
Nov 15, 2019

Conversation

brian-mann
Copy link
Member

@brian-mann brian-mann commented Nov 15, 2019 •
edited by jennifer-shehane
Loading

closes #5707
addresses #5698

User facing changelog

  • The context of window is no longer undefined within the application under test when called within a setTimeout during strict mode.

Additional details

How has the user experience changed?

The test below would previously fail - having window evaluate to undefined. Now it passes.

<!doctype html>
<html lang="en">
<body>
  <script>
    'use strict';
    window.setTimeout(function () {
      this.foo = 'bar'
    }, 50)
  </script>
</body>
</html>
it('asserts', () => {
  cy.visit('index.html')
  cy.window().its('foo').should('eq', 'bar')
})

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?
  • [NA] Has a PR for user-facing changes been opened in cypress-documentation?
  • [NA] Have API changes been updated in the type definitions?
  • [NA] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 15, 2019

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@cypress
Copy link

cypress bot commented Nov 15, 2019


Test summary

3505 • 0 • 45 • 0

Run details
Project cypress
Status Passed
Commit ad92959
Started Nov 15, 2019 5:31 AM
Ended Nov 15, 2019 5:35 AM
Duration 03:47 💡
OS Linux Debian - 9.8
Browser Multiple

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jennifer-shehane jennifer-shehane self-requested a review November 15, 2019 13:50
jennifer-shehane
jennifer-shehane approved these changes Nov 15, 2019
View reviewed changes
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled this down and verified it works. Test lookst good. 👍

@jennifer-shehane jennifer-shehane merged commit ff6bdcd into develop Nov 15, 2019
@cypress-bot cypress-bot bot mentioned this pull request Nov 15, 2019
Closed
@jennifer-shehane jennifer-shehane mentioned this pull request Nov 15, 2019
Closed
@emilyrohrbough emilyrohrbough deleted the issue-5707 branch August 1, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennifer-shehane jennifer-shehane jennifer-shehane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The context of window is undefined when called within a setTimeout during strict mode
2 participants
@brian-mann @jennifer-shehane