-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed null JSON file error. #5562
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
packages/driver/test/cypress/integration/commands/xhr_spec.coffee
Outdated
Show resolved
Hide resolved
packages/driver/test/cypress/integration/commands/xhr_spec.coffee
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost there, just would love to have an assertion that checks the received response client-side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, solves the problem
User facing changelog
Fixed a bug where fixtures consisting only of
null
would cause an error.Additional details
Why was this change necessary?
null
is a valid JSON. But it raises an error.What is affected by this change?
N/A
Any implementation details to explain?
N/A
How has the user experience changed?
PR Tasks
Has a PR for user-facing changes been opened incypress-documentation
?Have API changes been updated in thetype definitions
?Have new configuration options been added to thecypress.schema.json
?