Adding presets for following viewports: 1) iPhone-XR, 2) iPhone-X, 3)… #4967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Samsung-S10, 4) Samsung-Note9
|
|
… Samsung-S10, 4) Samsung-Note9
|
Thanks for the contribution! Could you please sign our CLA? |
@jennifer-shehane I have signed the CLA, although the status says its Pending. |
|
@jennifer-shehane : Thank-you for your inputs, have signed the CLA now. |
|
@ccodecamp Great. I'll bring this PR up with the team and we will get some feedback to you by early next week. Thanks for your patience. |
|
Thank-you so much @jennifer-shehane |
flotwig
previously approved these changes
Aug 26, 2019
There was a problem hiding this comment.
LGTM, used https://vizdevices.yesviz.com/ to validate viewport dimensions
flotwig
approved these changes
Aug 26, 2019
grabartley
pushed a commit
to grabartley/cypress
that referenced
this pull request
Oct 6, 2019
cypress-io#4967) * Adding presets for following viewports: 1) iPhone-XR, 2) iPhone-X, 3) Samsung-S10, 4) Samsung-Note9 * Adding presets for following viewports: 1) iPhone-XR, 2) iPhone-X, 3) Samsung-S10, 4) Samsung-Note9 * Fix casing * Cleanup * Update window_spec
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Samsung-S10, 4) Samsung-Note9
Adds support to more preset viewports
Pre-merge Tasks
cypress-documentationbeen submitted to document any user-facing changes?