-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 28187 Include checkVisibility browser API as a reliable tool to check visibility #29741
fix: 28187 Include checkVisibility browser API as a reliable tool to check visibility #29741
Conversation
|
…//github.com/senpl/cypress into issue-28187-IncludeCheckVisibilityBrowserAPI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@senpl There are some failures in the assertions spec in CI for this change.
…//github.com/senpl/cypress into issue-28187-IncludeCheckVisibilityBrowserAPI
This related to visibility fixed. |
@senpl All of the tests will need to be passing in order for us to merge, with no breaking changes to users. |
We've decided to prioritize looking into these visibility fixes in Quarter 4 of this year, when we intend to spend time on Cypress 14 release. It will ease any concerns we have around releasing breaking changes with these fixes and also help us plan the proper time to review these. Tracking here: #29925 |
Updated the base branch to go against release/14.0.0 |
Closing. Discussed this with the team and we are going to hold off on adding the |
Visibility check in browser is close to one used in cypress. Still some test has to be changed to make it compatible with what is really seen in browser.
If backward compatibility is required then some option could be applied to make elements previously invisible still detected as invisible. Still default should be compatible with browser implementation.
Include
checkVisibility
browser API as a reliable tool to check visibility #28187Additional details
It should close many other visibility issues,
Steps to test
How has the user experience changed?
Users should now use is hidden not is visible. Because some element might be visible still not really clicable or interactable.
In old version that two was connected. But hidden is not the same as visible. So this change make it compatible with other frameworks implementation.
PR Tasks
cypress-documentation
?type definitions
?