Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 28187 Include checkVisibility browser API as a reliable tool to check visibility #29741

Conversation

senpl
Copy link

@senpl senpl commented Jun 25, 2024

Visibility check in browser is close to one used in cypress. Still some test has to be changed to make it compatible with what is really seen in browser.
If backward compatibility is required then some option could be applied to make elements previously invisible still detected as invisible. Still default should be compatible with browser implementation.

Additional details

It should close many other visibility issues,

Steps to test

//this now should work
cy.get('details')
  .children('div')
  .should('not.be.visible') 

How has the user experience changed?

Users should now use is hidden not is visible. Because some element might be visible still not really clicable or interactable.
In old version that two was connected. But hidden is not the same as visible. So this change make it compatible with other frameworks implementation.

PR Tasks

@cypress-app-bot
Copy link
Collaborator

@senpl senpl changed the title fix 28187 Include checkVisibility browser API as a reliable tool to check visibility fix: 28187 Include checkVisibility browser API as a reliable tool to check visibility Jun 25, 2024
@senpl senpl marked this pull request as ready for review June 25, 2024 10:35
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@senpl There are some failures in the assertions spec in CI for this change.

@senpl
Copy link
Author

senpl commented Jun 27, 2024

This related to visibility fixed.

@jennifer-shehane
Copy link
Member

@senpl All of the tests will need to be passing in order for us to merge, with no breaking changes to users.

@jennifer-shehane
Copy link
Member

We've decided to prioritize looking into these visibility fixes in Quarter 4 of this year, when we intend to spend time on Cypress 14 release. It will ease any concerns we have around releasing breaking changes with these fixes and also help us plan the proper time to review these. Tracking here: #29925

@jennifer-shehane jennifer-shehane marked this pull request as draft August 14, 2024 15:13
@jennifer-shehane jennifer-shehane removed their request for review August 15, 2024 14:02
@jennifer-shehane jennifer-shehane added the Cypress 14 Issues scoped for Cypress 14 label Sep 27, 2024
@senpl senpl marked this pull request as ready for review September 30, 2024 09:15
@jennifer-shehane jennifer-shehane changed the base branch from develop to release/14.0.0 September 30, 2024 15:27
@jennifer-shehane
Copy link
Member

Updated the base branch to go against release/14.0.0

@jennifer-shehane jennifer-shehane requested review from mschile and removed request for jennifer-shehane November 13, 2024 16:04
@mschile
Copy link
Contributor

mschile commented Dec 2, 2024

Closing. Discussed this with the team and we are going to hold off on adding the checkVisibility API for now.

@mschile mschile closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cypress 14 Issues scoped for Cypress 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants