feat: add CT support for angular 18 #29584
Conversation
Passing run #55684 ↗︎
Details:
Review all test suite changes for PR #29584 ↗︎ |
|||||||||||||||
AtofStryker
force-pushed
the
feat/support_angular_18
branch
from
203aeaa to
7468794
Compare
|
This PR does not support angular signals, but that is being worked on separately. We likely want to introduce this PR first so users can get scaffolded angular 18 support in the CLI, then introduce our new signals test harness that users consuming signals in angular 17 and 18 can leverage. At some point, we will want to merge this new test harness upstream and deprecate support for older versions of angular |
AtofStryker
force-pushed
the
feat/support_angular_18
branch
from
aed9201 to
0c3a327
Compare
|
|
||
| **Bugfixes:** | ||
|
|
||
| - Fixed an issue where `inlineSourceMaps` was still being used when `sourceMaps` was provided in a users typescript config for typescript version 5. Fixes [#26203](https://github.com/cypress-io/cypress/issues/26203). |
There was a problem hiding this comment.
This is a wonderful fix BTW. I run into this all the time when running Angular apps with CT 👍
There was a problem hiding this comment.
Thank you. It actually went in with #29568 but I forgot to update the changelog after release so the change entry was in the wrong cypress version 😬 .
| "@angular/platform-browser": "^17.0.0-rc.2", | ||
| "@angular/platform-browser-dynamic": "^17.0.0-rc.2", | ||
| "@angular/router": "^17.0.0-rc.2", | ||
| "@angular/animations": "^17.3.10", |
There was a problem hiding this comment.
Great job cleaning this up btw.
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
This PR adds support for Angular 18 CT which was released last week. From what I can see from the Angular 18 Changelog there isn't anything for me to believe the changes to
@angular/coreand other packages cause our test harness to break. With that being said, the only requirement was to add support in the scaffolded dependencies and added Angular 18 system tests.This PR also updates the angular 17 system test to not use the release candidate and instead use the published version
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?