-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update cypress to Typescript 5 #29568
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
3b981df
fix: update the monorepo to typescript 5
AtofStryker 0672d61
chore: updating v8 snapshot cache
0d41e9e
chore: updating v8 snapshot cache
d7e4715
chore: updating v8 snapshot cache
e45d70a
run ci to see problems [run ci]
AtofStryker ea3af5c
update vue-tsc and typings that conflict with update
AtofStryker bf053a6
regen snapshot
AtofStryker 8b371ac
fix typescript errors ui test as stack trace behavior has changed
AtofStryker 15cd2bf
fix server unit tests
AtofStryker 44ce327
update cy.origin() spec based on stack traces and code frames
AtofStryker d0c95cc
update spec to include source map url
AtofStryker 4a7c8ca
run ci
AtofStryker 9342cd5
fix check-ts
AtofStryker 62c449a
chore: fix system tests [run ci]
AtofStryker 1df72d8
add preprocessor tests to batteries included to exercise new logic
AtofStryker 5b4650e
run ci
AtofStryker 273f6df
refactor unit tests to be a bit more dry
AtofStryker d3916e9
pin typescript to ~5.4 and adjust config to ignroe deprecations but k…
AtofStryker 0c9e81e
add changelog entry
AtofStryker 307eb28
add fixme issue to stack trace mismatches inside evaled context
AtofStryker 93932f9
use import type webpack as webpack as a lib isn't actually invboked i…
AtofStryker 1a559d5
Merge branch 'develop' of github.com:cypress-io/cypress into fix/upda…
AtofStryker 75b8722
fix system test as adding 4 lines of comments impacts the stack trace…
AtofStryker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this preserves the existing behavior without throwing an error - imports that are not used as values will simply be stripped, since
verbatimModuleSyntax
is not enabled. Is that intended?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is just oversight on my end. I need to add
"verbatimModuleSyntax": true
to get the expected behavior. good catch!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we will need to address this separately, since we cant use
"verbatimModuleSyntax": true
withimport
syntax inside common js modules. I wonder if we want to make an issue to reword the modules to leverage"verbatimModuleSyntax": true
since there isn't anything that leads me to believe this is an issue?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have any polyfills or other content where this would be an issue but not entirely sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we just want to pin to
~5.4.5
for the time being so we aren't subject to the breaking change in5.5
with the removal of"importsNotUsedAsValues": "error"
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cacieprins I wound up going with the above comment in d3916e9