feat: support Next.JS version 14 #29558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: this does not resolve #29552 |
AtofStryker
changed the title
AtofStryker
force-pushed
the
feat/support_next_14
branch
from
94f9e9e to
f0eb4fe
Compare
AtofStryker
commented
May 23, 2024
| module.exports = { | ||
| component: { | ||
| experimentalSingleTabRunMode: true, | ||
| devServer: {}, | ||
| devServer: { |
There was a problem hiding this comment.
I think this was just missed previously when we added next support
ryanthemanuel
approved these changes
May 23, 2024
AtofStryker
commented
May 23, 2024
| @@ -2408,7 +2408,7 @@ Your configFile threw an error from: cypress-webpack.config.ts | |||
| We stopped running your tests because your config file crashed. | |||
|
|
|||
| CypressWebpackDevServerError: Incompatible major versions of webpack and webpack-dev-server! | |||
| webpack-dev-server major version 5 only works with major versions of webpack 4 - saw webpack-dev-server version 5.0.4. | |||
| webpack-dev-server major version 5 only works with major versions of webpack 5 - saw webpack-dev-server version 5.0.4. | |||
There was a problem hiding this comment.
noticed this error was wrong so fixed it here
mschile
reviewed
May 29, 2024
mschile
reviewed
May 29, 2024
mschile
approved these changes
May 29, 2024
Co-authored-by: Matt Schile <[email protected]>
Co-authored-by: Matt Schile <[email protected]>
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Adds CT support for Next.JS version 14. The main code change here is to make the CLI not complain when a user has Next.JS 14 installed since the support of wds 5 in #29306 and fixing resolution with
moduleResolution: "bundler" in #28709 otherwise make Next.JS 14 work OOTB.In addition, a lot of our tests have been updated to at least use the last two versions of Next.JS (13 & 14) to make sure compatibility works, including a Next.JS 14 test with tailwind and default typescript configuration to make sure CT testing works out of the box. Other tests have also been additionally updated.
Steps to test
How has the user experience changed?
Users of Next.JS Component Testing will no longer see the support banner warning in the app.
PR Tasks
cypress-documentation?type definitions?