misc: allow HiDPI Screen running wayland to use cypress window/browser #29366
Conversation
|
|
|
azvyae
changed the title
|
@azvyae Thanks for the contribution! Can you add a changelog entry to this? https://github.com/cypress-io/cypress/blob/develop/guides/writing-the-cypress-changelog.md#when-to-add-an-entry |
|
Docs on ozone-platform flag: https://chromium.googlesource.com/chromium/src/+/HEAD/docs/ozone_overview.md |
|
Hey thanks @jennifer-shehane for the reply, just already fixed it. Feel free to ask if there is anything else to do |
| @@ -155,7 +155,7 @@ module.exports = { | |||
|
|
|||
| const { onStderrData } = overrides | |||
| const envOverrides = util.getEnvOverrides(options) | |||
| const electronArgs = [] | |||
| const electronArgs = ['--ozone-platform=auto'] | |||
There was a problem hiding this comment.
@azvyae, I believe that the tests here will need to be updated for this change: https://github.com/cypress-io/cypress/blob/develop/cli/test/lib/exec/spawn_spec.js#L117 (and possibly more below this test).
There was a problem hiding this comment.
Is that part of ci/circleci: unit-tests workflow? If it is, how actually added more xml test reports to the repo?
There was a problem hiding this comment.
@azvyae, yeah that's the workflow. There's a bug in CI we have sometimes where the unit tests fail and it causes a report to not get generated for a specific package's unit tests and that's the error that we're seeing there. You should be able to see what's failing locally if you run:
yarn workspace cypress test-unit
There was a problem hiding this comment.
Note that I'm fixing the issue I mentioned above here: #29481
This will make tracking down the unit test failures easier once it lands.
|
@azvyae, the failing unit tests are now showing up properly on the CI job:
|
|
@azvyae Will you be able to address the failing unit tests? |
|
@azvyae Will you be able to address the failing unit tests? We may need to close the PR if not addressed. |
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
High demand of HiDPI Screen and multi monitor setups make people tend to use fractional scaling for each their own monitor differently. Problem happens when using chromium based app that can lead to blurriness of the UI. By providing simple flag to the electron arguments
--ozone-platform=autowhich literally can backwards compatible will help Wayland users to use chromium/electron without blurry texts, the flag also compatible with x11 window system if it's the only available option.Just small change to add the flag to the spawn.js file
Steps to test
It's already tested here
PR Tasks
cypress-documentation?type definitions?