-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: use pnpm add for ct dependency scaffolding #29056
Merged
jennifer-shehane
merged 9 commits into
cypress-io:develop
from
MikeMcC399:issue-29052-ct-pnpm-scaffolding
Mar 12, 2024
Merged
misc: use pnpm add for ct dependency scaffolding #29056
jennifer-shehane
merged 9 commits into
cypress-io:develop
from
MikeMcC399:issue-29052-ct-pnpm-scaffolding
Mar 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jennifer-shehane
approved these changes
Mar 5, 2024
mschile
approved these changes
Mar 5, 2024
Seems we can't get the tests to pass due to recent tests added, we're looking into it: #29072 |
The issue with the failing tests has been resolved, so going to work on merging this in. Hold off on pulling in develop unless there are conflicts. |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pnpm install
notadd
#29052Additional details
Cypress Component Testing was instructing the user to add framework dependencies using
pnpm install
when the underlying project was using pnpm as package manager. This was inconsistent with the pnpm cli documentation which listspnpm add <pkg>
as the appropriate command to add a package.Steps to test
22.04.4
LTS18.17.1
Prepare project
cy-pnpm-ct
npm install pnpm@latest -g mkdir cy-pnpm-ct cd cy-pnpm-ct git init pnpm init pnpm add cypress -D
Local Cypress build and run
In the Cypress Launchpad use "Add project" to select the directory
cy-pnpm-ct
Select "Component Testing"
Select "Front-end framework" > "Vue CLI (Vue 3)"
Click "Next step"
Note the instruction
Paste the instruction into a separate terminal window which is open in the directory
cy-pnpm-ct
and execute it.Note that it runs successfully.
Back in the Cypress Launchpad confirm that the status message "You've successfully installed all required dependencies." is shown.
How has the user experience changed?
When scaffolding Component Testing for a project using pnpm as package manager the Cypress Launchpad previously showed the instruction to install the required dependencies in the form
and now it shows the instruction in the following form:
BEFORE
AFTER
PR Tasks
cypress-documentation
?The documentation Component Testing > Getting Started only covers npm (not Yarn or pnpm) and does not cover the case where dependencies have not yet been installed, so the changes in this PR do not affect any existing documentation.
type definitions
?