-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update getPath to use WHATWG URL API #28354
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschile
changed the title
fix: decode urls in prerequest
fix: update getPath to use WHATWG URL API
Nov 20, 2023
ryanthemanuel
approved these changes
Nov 20, 2023
emilyrohrbough
approved these changes
Nov 20, 2023
4 flaky tests on run #52397 ↗︎
Details:
runs.cy.ts • 1 flaky test • app-e2e
cypress-in-cypress.cy.ts • 1 flaky test • app-e2e
specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
debug.cy.ts • 1 flaky test • app-e2e
Review all test suite changes for PR #28354 ↗︎ |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
getPath
method to use the WHATWG URL API.When processing requests, we set the url using the legacy url API. Since this API is not WHATWG URL API compliant with respect to percent encoding, we receive a path that may be different from what CDP sends causing prerequest correlation timeouts of two seconds.
The following requests were observed in the wild:
With the encoded
|
as%7C
:https://fonts.googleapis.com/css?family=Roboto+Mono%7COpen+Sans:700&display=swap
Already decoded
|
:https://fonts.googleapis.com/css?family=Roboto+Mono|Open+Sans:700&display=swap
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?