Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update getPath to use WHATWG URL API #28354

Merged
merged 9 commits into from
Nov 20, 2023
Merged

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Nov 16, 2023

Additional details

When processing requests, we set the url using the legacy url API. Since this API is not WHATWG URL API compliant with respect to percent encoding, we receive a path that may be different from what CDP sends causing prerequest correlation timeouts of two seconds.

The following requests were observed in the wild:

With the encoded | as %7C:
https://fonts.googleapis.com/css?family=Roboto+Mono%7COpen+Sans:700&display=swap

Already decoded |:
https://fonts.googleapis.com/css?family=Roboto+Mono|Open+Sans:700&display=swap

Steps to test

How has the user experience changed?

PR Tasks

@mschile mschile changed the title fix: decode urls in prerequest fix: update getPath to use WHATWG URL API Nov 20, 2023
Copy link

cypress bot commented Nov 20, 2023

4 flaky tests on run #52397 ↗︎

0 554 6 0 Flakiness 4

Details:

Merge branch 'develop' into mschile/decode_prerequest
Project: cypress Commit: ad62dfb092
Status: Passed Duration: 12:48 💡
Started: Nov 20, 2023 7:32 PM Ended: Nov 20, 2023 7:45 PM
Flakiness  runs.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
... > displays each run with correct information Test Replay Screenshots
Flakiness  cypress-in-cypress.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
Cypress in Cypress > restarts browser if there is a before:browser:launch task and there is a change on the config Test Replay Screenshots
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Test Replay Screenshots
Flakiness  debug.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
App - Debug Page > shows running and updating build Test Replay Screenshots

Review all test suite changes for PR #28354 ↗︎

@mschile mschile merged commit d964865 into develop Nov 20, 2023
80 of 82 checks passed
@mschile mschile deleted the mschile/decode_prerequest branch November 20, 2023 19:46
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 21, 2023

Released in 13.6.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants