fix: issue with service worker attachments #28147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Emily Rohrbough <[email protected]>
4 flaky tests on run #51897 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Test Replay
Output
|
|
| ... > correctly returns currentRetry |
Test Replay
Output
|
|
| ... > correctly returns currentRetry |
Test Replay
Output
|
|
e2e/origin/snapshots.cy.ts • 1 flaky test • 5x-driver-chrome:beta
Review all test suite changes for PR #28147 ↗︎
chrisbreiding
approved these changes
Oct 26, 2023
emilyrohrbough
approved these changes
Oct 26, 2023
ryanthemanuel
deleted the
ryanm/fix/crash-with-service-worker-attachments
branch
|
|
Thanks @MikeMcC399, we're still working on getting a release out. |
|
Shouldn't the https://github.com/apps/cypress-bot run to mark this as released? |
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
When we added logic to ensure we were attaching to CDP traffic we were not resilient enough to handle situations where the worker targets would attach and the immediately be closed (this can happen due to navigations or refreshing of the page). To fix this we will catch the errors. There's nothing really to do if the targets have been disposed anyway.
Steps to test
n/a
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?