Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency: updated chrome-remote-interface to 0.33.0 #27998

Merged
merged 26 commits into from
Nov 20, 2023

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Oct 6, 2023

Additional details

Updated chrome-remote-interface to 0.33.0 to increase the max CDP payload from 100MB to 256MB.

Steps to test

How has the user experience changed?

PR Tasks

@cypress
Copy link

cypress bot commented Oct 6, 2023

6 flaky tests on run #52392 ↗︎

0 554 6 0 Flakiness 6

Details:

Merge branch 'mschile/update_cri_version' of https://github.com/cypress-io/cypre...
Project: cypress Commit: ea170000f7
Status: Passed Duration: 12:52 💡
Started: Nov 20, 2023 6:49 PM Ended: Nov 20, 2023 7:02 PM
Flakiness  runs.cy.ts • 2 flaky tests • app-e2e

View Output

Test Artifacts
App: Runs > Runs - Create Project > when a project is created, injects new projectId into the config file, and sends expected UTM params Test Replay Screenshots
App: Runs > Runs - No Runs > displays a copy button and copies correct command in Component Testing Test Replay Screenshots
Flakiness  specs_list_e2e.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
... > saves the filter when navigating to a spec and back Test Replay Screenshots
Flakiness  cypress-in-cypress.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
Cypress in Cypress > restarts browser if there is a before:browser:launch task and there is a change on the config Test Replay Screenshots
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Test Replay Screenshots
Flakiness  debug.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
App - Debug Page > shows information about a failed spec Test Replay Screenshots

Review all test suite changes for PR #27998 ↗︎

@@ -202,7 +202,7 @@ async function makeE2ETasks () {
process.chdir(cachedCwd)
testState = {}
remoteGraphQLOptions = {}
await DataContext.waitForActiveRequestsToFlush()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the implications of this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be like @cacieprins said, this is setup like a singleton & isn't being reset between cy & cy runs. I have not observed any issues with resetting this. The rest is handled on line 209 with cy.reinitializeCypress().

@jordanpowell88 jordanpowell88 merged commit a22fd5c into develop Nov 20, 2023
@jordanpowell88 jordanpowell88 deleted the mschile/update_cri_version branch November 20, 2023 21:08
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 21, 2023

Released in 13.6.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants