-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependency: updated chrome-remote-interface to 0.33.0 #27998
Conversation
…ss-io/cypress into mschile/update_cri_version
…ss-io/cypress into mschile/update_cri_version
@@ -202,7 +202,7 @@ async function makeE2ETasks () { | |||
process.chdir(cachedCwd) | |||
testState = {} | |||
remoteGraphQLOptions = {} | |||
await DataContext.waitForActiveRequestsToFlush() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the implications of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be like @cacieprins said, this is setup like a singleton & isn't being reset between cy & cy runs. I have not observed any issues with resetting this. The rest is handled on line 209 with cy.reinitializeCypress()
.
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
Updated
chrome-remote-interface
to 0.33.0 to increase the max CDP payload from 100MB to 256MB.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?