Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update @ffprobe-installer/ffprobe so all system tests can run on darwin-arm64 #27802

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

cacieprins
Copy link
Contributor

  • Closes

Additional detai

Previously, running the entire suite of system tests would fail quickly on darwin-arm64 with Error: Unsupported platform/architecture: darwin-arm64. Updating @ffprobe-installer/ffprobe fixes the issue.

This is a major version update for the dependency, but the only change from 1.x was removing support for node <14.

Steps to test

Run system tests on darwin-arm64

How has the user experience changed?

PR Tasks

@cacieprins cacieprins marked this pull request as ready for review September 13, 2023 15:05
@cypress
Copy link

cypress bot commented Sep 13, 2023

2 flaky tests on run #51320 ↗︎

0 217 21 0 Flakiness 2

Details:

Merge branch 'develop' into chore/cacie/update-ffprobe-installer
Project: cypress Commit: e779739d20
Status: Passed Duration: 09:50 💡
Started: Sep 27, 2023 7:47 PM Ended: Sep 27, 2023 7:57 PM
Flakiness  cypress/e2e/scaffold-component-testing.cy.ts • 2 flaky tests • launchpad-e2e

View Output Video

Test Artifacts
scaffolding component testing > vuecli4vue2 > scaffolds component testing for Vue CLI 4 w/ Vue 2 project Test Replay Output Screenshots
scaffolding component testing > react-vite-ts-unconfigured > scaffolds component testing for React and Vite Test Replay Output Screenshots

Review all test suite changes for PR #27802 ↗︎

@cacieprins cacieprins merged commit b4cfb47 into develop Oct 26, 2023
5 checks passed
@cacieprins cacieprins deleted the chore/cacie/update-ffprobe-installer branch October 26, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants