fix: report results correctly when the browser crashes mid-test #27786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cacieprins
commented
Sep 11, 2023
6 flaky tests on run #51513 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
Review all test suite changes for PR #27786 ↗︎
cacieprins
commented
Sep 19, 2023
chrisbreiding
approved these changes
Sep 21, 2023
mjhenkes
reviewed
Oct 6, 2023
| @@ -376,7 +376,6 @@ export class ProjectBase extends EE { | |||
| }, | |||
|
|
|||
| onMocha: async (event, runnable) => { | |||
| debug('onMocha', event) | |||
mjhenkes
reviewed
Oct 6, 2023
| import type { Browser } from '../browsers/types' | ||
| import * as printResults from '../util/print-run' | ||
| import type { ProtocolManager } from '../cloud/protocol' | ||
| import { telemetry } from '@packages/telemetry' | ||
| import { CypressRunResult, createPublicBrowser, createPublicConfig, createPublicRunResults, createPublicSpec, createPublicSpecResults } from './results' | ||
| import { EarlyExitTerminator } from '../util/graceful_crash_handling' |
mjhenkes
approved these changes
Oct 6, 2023
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This reports on tests that cannot be completed, focusing on the scenario where the browser renderer crashes during a test run. Reporting test runs correctly even when a spec causes the browser to crash is required to support test replay on those specs.
To this end, it:
Future work, either on this branch or others, will include additional handling for various other scenarios where tests cannot be run.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?