Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add driver, reporter, config as implicit dependencies for runner package #27559

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

astone123
Copy link
Contributor

@astone123 astone123 commented Aug 15, 2023

This PR adds the following packages as implicit dependencies of @packages/runner

  • @packages/driver
  • @packages/config
  • @packages/reporter

we need to do this because our run-webpack script builds and rolls up the source files for driver, config, and reporter into the build assets of the runner package in packages/dist/cypress_runner.js. So, we need to specify these projects as implicit dependencies of the runner project so that any time we change the source in any of the packages above, @packages/runner:build is run again from source.

@astone123 astone123 self-assigned this Aug 15, 2023
@cypress
Copy link

cypress bot commented Aug 15, 2023

8 flaky tests on run #50014 ↗︎

0 5325 78 0 Flakiness 8

Details:

chore: add driver, reporter, config as implicit dependencies for runner package
Project: cypress Commit: f012d1b415
Status: Passed Duration: 15:56 💡
Started: Aug 16, 2023 4:08 AM Ended: Aug 16, 2023 4:24 AM
Flakiness  e2e/origin/cookie_login.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin - cookie login > general behavior > works in a session Output Video
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
network stubbing > intercepting request > can reply with a JSON fixture Output Video
Flakiness  e2e/origin/commands/querying.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin querying > .get() Output Video
Flakiness  e2e/origin/commands/actions.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin actions > .type() Output Video
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video

The first 5 flaky specs are shown, see all 6 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@AtofStryker AtofStryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is lerna smart enough here to rebuild a package if there is an explicit dependency on it?

like the app package depends on the frontend-shared package, which is defined as an explicit dependency in the package.json. If frontend-shared changes in this case, does the app cache bust and rebuild?

@astone123
Copy link
Contributor Author

is lerna smart enough here to rebuild a package if there is an explicit dependency on it?

like the app package depends on the frontend-shared package, which is defined as an explicit dependency in the package.json. If frontend-shared changes in this case, does the app cache bust and rebuild?

Yes, if there are changes in frontend-shared, then the next time app builds it will not be cached because its dependencies have changed.

You can take a look at the dependency graph and how different packages depend on each other by running "yarn nx graph"

@astone123 astone123 merged commit ae4cf2b into develop Aug 16, 2023
@astone123 astone123 deleted the astone123/runner-implicit-deps branch August 16, 2023 04:21
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 29, 2023

Released in 13.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants