-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add driver, reporter, config as implicit dependencies for runner package #27559
Conversation
8 flaky tests on run #50014 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
cy.origin - cookie login > general behavior > works in a session |
Output
Video
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron
Test | Artifacts | |
---|---|---|
network stubbing > intercepting request > can reply with a JSON fixture |
Output
Video
|
e2e/origin/commands/querying.cy.ts • 1 flaky test • 5x-driver-electron
Test | Artifacts | |
---|---|---|
cy.origin querying > .get() |
Output
Video
|
e2e/origin/commands/actions.cy.ts • 1 flaky test • 5x-driver-electron
Test | Artifacts | |
---|---|---|
cy.origin actions > .type() |
Output
Video
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron
Test | Artifacts | |
---|---|---|
... > correctly returns currentRetry |
Output
Video
|
|
... > correctly returns currentRetry |
Output
Video
|
|
... > correctly returns currentRetry |
Output
Video
|
The first 5 flaky specs are shown, see all 6 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is lerna smart enough here to rebuild a package if there is an explicit dependency on it?
like the app
package depends on the frontend-shared
package, which is defined as an explicit dependency in the package.json
. If frontend-shared
changes in this case, does the app cache bust and rebuild?
Yes, if there are changes in frontend-shared, then the next time app builds it will not be cached because its dependencies have changed. You can take a look at the dependency graph and how different packages depend on each other by running "yarn nx graph" |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
This PR adds the following packages as implicit dependencies of
@packages/runner
we need to do this because our
run-webpack
script builds and rolls up the source files fordriver
,config
, andreporter
into the build assets of therunner
package inpackages/dist/cypress_runner.js
. So, we need to specify these projects as implicit dependencies of therunner
project so that any time we change the source in any of the packages above,@packages/runner:build
is run again from source.