-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade lerna to 6, cache build step #26913
Changes from all commits
8e90764
5fdf503
2ae9834
5c542b6
52e8749
7a3e0c5
4ce8303
a907650
e4fa53c
0de66ba
f6f248c
3187987
157ad39
63fb938
81c4d6e
6dec4a0
0c1fc8c
c4d5aab
1e00362
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -176,5 +176,15 @@ | |
"nohoist": [ | ||
"@types/*" | ||
] | ||
}, | ||
"nx": { | ||
"targets": { | ||
"build": { | ||
"outputs": [ | ||
"{projectRoot}/types", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We have to specify these outputs because we generate |
||
"{projectRoot}/build" | ||
] | ||
} | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,6 @@ | |
"prebuild": "rimraf dist", | ||
"build": "rollup -c rollup.config.mjs", | ||
"postbuild": "node ../../scripts/sync-exported-npm-with-cli.js", | ||
"build-prod": "yarn build", | ||
"check-ts": "tsc --noEmit", | ||
"lint": "eslint --ext .js,.ts,.json, ." | ||
}, | ||
|
@@ -59,6 +58,18 @@ | |
"publishConfig": { | ||
"access": "public" | ||
}, | ||
"nx": { | ||
"targets": { | ||
"build": { | ||
"inputs": [ | ||
"{workspaceRoot}/scripts" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We specify |
||
], | ||
"outputs": [ | ||
"{workspaceRoot}/cli/angular" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because we copy these assets to the |
||
] | ||
} | ||
} | ||
}, | ||
"standard": { | ||
"globals": [ | ||
"Cypress", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,6 @@ | |
"main": "dist/src/main.js", | ||
"scripts": { | ||
"build": "yarn prepare-example && tsc -p ./tsconfig.json && node scripts/example copy-to ./dist/initial-template && yarn prepare-copy-templates", | ||
"build-prod": "yarn build", | ||
"prepare-example": "node scripts/example copy-to ./initial-template", | ||
"prepare-copy-templates": "node scripts/copy-templates copy-to ./dist/src", | ||
"test": "cross-env TS_NODE_PROJECT=./tsconfig.test.json mocha --config .mocharc.json './src/**/*.test.ts'", | ||
|
@@ -23,14 +22,15 @@ | |
"commander": "6.2.1", | ||
"find-up": "5.0.0", | ||
"fs-extra": "^9.1.0", | ||
"inquirer": "7.3.3", | ||
"glob": "^7.1.6", | ||
"inquirer": "8.2.4", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a required change as Lerna 6 depends upon |
||
"ora": "^5.1.0", | ||
"recast": "0.20.4", | ||
"semver": "7.3.7" | ||
}, | ||
"devDependencies": { | ||
"@types/babel__core": "^7.1.2", | ||
"@types/inquirer": "7.3.1", | ||
"@types/inquirer": "8.2.4", | ||
"@types/mock-fs": "4.10.0", | ||
"@types/node": "16.18.39", | ||
"@types/ora": "^3.2.0", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,5 +54,16 @@ | |
"ng-add": { | ||
"save": "devDependencies" | ||
}, | ||
"nx": { | ||
"targets": { | ||
"build": { | ||
"outputs": [ | ||
"{projectRoot}/src/**/*.js", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We have to specify these like this because we currently do not place build assets in an |
||
"{projectRoot}/src/**/*.d.ts", | ||
"{projectRoot}/src/**/*.js.map" | ||
] | ||
} | ||
} | ||
}, | ||
"schematics": "./src/schematics/collection.json" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order for these jobs to leverage caching we need to change them from
yarn workspace
commands toyarn lerna run
commands