feat: Add Buddy to supported Cloud CI Providers #26848
Conversation
|
Ben M seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
trojano31
force-pushed
the
detect-buddy-ci-cd
branch
from
8a51392 to
109455a
Compare
|
Buddy.works is listed on https://github.com/cypress-io/cypress-example-kitchensink#ci-workflow-examples as a documentation-only example. It is however not on the list on https://docs.cypress.io/guides/continuous-integration/ci-provider-examples I haven't seen it mentioned in the Cypress Discord chats so far. |
nagash77
added
type: feature
|
Hello Mike, |
|
Hi @trojano31 Thanks for outlining your role at Buddy and explaining the need! Any decisions about implementing the feature request which you submitted in this PR would need to come from the Cypress.io engineering team. Regarding your related question about the listing on https://docs.cypress.io/guides/continuous-integration/ci-provider-examples: the documentation is sourced from the repository https://github.com/cypress-io/cypress-documentation, so if you want to suggest a documentation update it would need to be placed there, either as an issue or as a PR. Again, any decisions about content would be made by the Cypress.io team. |
There was a problem hiding this comment.
Awesome!! Thank you for the contribution!
Would you mind adding the Buddy CI example to our docs in cypress-io/cypress-documentation, as Mike indicated?
emilyrohrbough
changed the title
There was a problem hiding this comment.
PR looks good! I am working on getting contributor PRs running properly in CI in #26897. Once I have that working and merged in, we can pull into this branch and run the CI build
|
Congratulations on your suggestion being picked up! 🚀 Would you mind checking https://github.com/cypress-io/cypress-example-kitchensink/blob/master/buddy.yml to see if this workflow is correct and would work? It is documentation-only at this time, so there is no live check being done that it works. |
| @@ -197,6 +198,16 @@ const _providerCiParams = () => { | |||
| 'BUILDKITE_PULL_REQUEST_BASE_BRANCH', | |||
| 'BUILDKITE_RETRY_COUNT', | |||
| ]), | |||
| // All available vars | |||
There was a problem hiding this comment.
@trojano31 @estrada9166 on our Cloud team pointed this out:
we need to still send the customCiBuildId in case record jobs that run it in parallel or with groups
This change would be made here: https://github.com/cypress-io/cypress-services/blob/develop/packages/util/src/ciProvider.ts#L25-L45
Looking at the Buddy envs, it looks like BUDDY_PIPELINE_ID and BUDDY_EXECUTION_ID would satisfy this.
There was a problem hiding this comment.
@emilyrohrbough I assume the change has to be done by the Cloud team as I don't have permissions to view this repository? However, I've added BUDDY_PIPELINE_ID to the list of extracted variables
# Conflicts: # cli/CHANGELOG.md
|
@emilyrohrbough sure thing, I'll add Buddy example to your docs! @MikeMcC399 this workflow uses our old YAML syntax for pipelines but we still support it and it totally works - I've checked it. I'll update it, however, to the current one :) |
I couldn't see any change or PR for this. Are you still planning to do an update to the following file? https://github.com/cypress-io/cypress-example-kitchensink/blob/master/buddy.yml |
Additional details
Adding Buddy CI/CD to ci provider to let user use its build variables.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?