Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace fast-glob with globby; remove unneeded getenv dep #26730

Merged
merged 4 commits into from
Jun 5, 2023

Conversation

emilyrohrbough
Copy link
Member

  • Replace fast-glob with globby. Globby is built on fast-glob, so it is still in the yarn lock dep tree, however, it is one less glob dep to manage. currently we have glob, globby and fast-glob in the repo. One should really be enough.
  • remove getenv deps from server/graphql packages. it is only used in the data-context package.

PR Tasks

@cypress
Copy link

cypress bot commented May 11, 2023

3 flaky tests on run #47066 ↗︎

0 5193 77 0 Flakiness 3

Details:

Merge branch 'develop' into remove-fast-glob
Project: cypress Commit: 43258a3593
Status: Passed Duration: 14:14 💡
Started: Jun 5, 2023 5:58 PM Ended: Jun 5, 2023 6:12 PM
Flakiness  cypress/e2e/cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@emilyrohrbough emilyrohrbough merged commit 4d5f903 into develop Jun 5, 2023
@emilyrohrbough emilyrohrbough deleted the remove-fast-glob branch June 5, 2023 18:33
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 7, 2023

Released in 12.14.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.14.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants