chore: update Lerna to version 6 #26521
Conversation
jordanpowell88
changed the title
lerna.json
Outdated
| @@ -8,5 +8,6 @@ | |||
| "system-tests" | |||
| ], | |||
| "useWorkspaces": true, | |||
| "useNx": false, | |||
There was a problem hiding this comment.
Once we get to a point where we can flip this switch we will start to see some significant DX and CI improvements! 😄
49 failed and 8 flaky tests on run #45945 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
e2e/origin/uncaught_errors.cy.ts • 0 failed tests • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
The first 5 failed specs are shown, see all 869 specs in Cypress Cloud.
create-from-component.cy.ts • 2 flaky tests • app-e2e
| Test | Artifacts | |
|---|---|---|
| ... > runs generated spec |
Output
Screenshots
Video
|
|
| ... > runs generated spec |
Output
Screenshots
Video
|
|
e2e/origin/cookie_login.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| cy.origin - cookie login > Max-Age > past max-age -> not logged in |
Output
Video
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| network stubbing > intercepting request > can delay and throttle a StaticResponse |
Output
Video
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| network stubbing > intercepting request > can delay and throttle a StaticResponse |
Output
Video
|
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when waiting for 2nd response to route |
Output
Video
|
|
The first 5 flaky specs are shown, see all 6 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
jordanpowell88
force-pushed
the
jordanpowell88/lerna-6
branch
3 times, most recently
from
86cc3ea to
bd2f3d3
Compare
| @@ -207,7 +207,7 @@ | |||
| "through2": "^4.0.2", | |||
| "tree-kill": "1.2.2", | |||
| "ts-node": "^10.9.1", | |||
| "typescript": "^4.7.4", | |||
| "typescript": "4.7.4", | |||
| "inquirer": "7.3.3", | ||
| "inquirer": "8.2.4", | ||
| "ora": "^5.1.0", |
There was a problem hiding this comment.
This was necessary as the Lerna upgrade has a dependency upon inquirer.
See this release
It was throwing errors when building by leaving it at 7.3.3
There was a problem hiding this comment.
What were the inquire breaking changes? Where the scripts in our repo using this dependency tested/check to ensure no other changes were needed?
There was a problem hiding this comment.
package.json
Outdated
| @@ -174,7 +174,7 @@ | |||
| "inquirer": "3.3.0", | |||
| "inquirer-confirm": "2.0.3", | |||
| "lazy-ass": "1.6.0", | |||
| "lerna": "3.22.1", | |||
| "lerna": "6.2.0", | |||
There was a problem hiding this comment.
Can we use an open range?
jordanpowell88
force-pushed
the
jordanpowell88/lerna-6
branch
from
4bb5352 to
2526f4e
Compare
jordanpowell88
force-pushed
the
jordanpowell88/lerna-6
branch
from
c300655 to
413b5bf
Compare
jordanpowell88
force-pushed
the
jordanpowell88/lerna-6
branch
from
211332c to
e5bd016
Compare
|
closing in favor of #26660 |
Additional details
This updates Lerna from version 3 to version 6
Steps to test
Any package.json script using lerna should still function as expected.
How has the user experience changed?
n/a
PR Tasks
cypress-documentation?type definitions?