-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add linting to the scripts directory #26197
Merged
ryanthemanuel
merged 3 commits into
develop
from
ryanm/chore/add-linting-to-scripts-dir
Mar 23, 2023
Merged
chore: add linting to the scripts directory #26197
ryanthemanuel
merged 3 commits into
develop
from
ryanm/chore/add-linting-to-scripts-dir
Mar 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschile
reviewed
Mar 23, 2023
mjhenkes
approved these changes
Mar 23, 2023
AtofStryker
approved these changes
Mar 23, 2023
mschile
approved these changes
Mar 23, 2023
30 flaky tests on run #44928 ↗︎
Details:
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox
e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron
create-from-component.cy.ts • 2 flaky tests • app-e2e
The first 5 flaky specs are shown, see all 16 specs in Cypress Cloud. This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
We really should be linting the scripts directory as part of the build process. This PR enables that while cleaning up a few problems in the process. It also turns off console warnings in directories like scripts and tooling which don't directly affect our consumers.
Steps to test
n/a
How has the user experience changed?
n/a
PR Tasks
cypress-documentation
?type definitions
?