Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add linting to the scripts directory #26197

Merged
merged 3 commits into from
Mar 23, 2023

Conversation

ryanthemanuel
Copy link
Collaborator

Additional details

We really should be linting the scripts directory as part of the build process. This PR enables that while cleaning up a few problems in the process. It also turns off console warnings in directories like scripts and tooling which don't directly affect our consumers.

Steps to test

n/a

How has the user experience changed?

n/a

PR Tasks

@ryanthemanuel ryanthemanuel requested a review from mschile March 23, 2023 16:26
@cypress
Copy link

cypress bot commented Mar 23, 2023

30 flaky tests on run #44928 ↗︎

0 26890 1281 0 Flakiness 30

Details:

remove last no-console
Project: cypress Commit: 4196669a42
Status: Passed Duration: 19:35 💡
Started: Mar 23, 2023 4:37 PM Ended: Mar 23, 2023 4:56 PM
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output
Flakiness  e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
cy.origin assertions > #consoleProps > .should() and .and() Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox

View Output Video

Test Artifacts
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
Flakiness  create-from-component.cy.ts • 2 flaky tests • app-e2e

View Output Video

Test Artifacts
... > runs generated spec Output Screenshots Video
... > runs generated spec Output Screenshots Video

The first 5 flaky specs are shown, see all 16 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@ryanthemanuel ryanthemanuel merged commit 0a4550e into develop Mar 23, 2023
@ryanthemanuel ryanthemanuel deleted the ryanm/chore/add-linting-to-scripts-dir branch March 23, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants