feat: create from React component #25168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ryan Manuel <[email protected]> Co-authored-by: Lachlan Miller <[email protected]>
Co-authored-by: astone123 <[email protected]>
…create-from-react-component
* feat: WIP server logic for create from React component * feat: add more tests; error handling * feat: WIP create from React UI * feat: PR feedback [run CI] * feat: try committing snapshot cache changes [run ci] * feat: try re-generating snapshot [run ci] * fix build * regenerate cache on darwin * update caches * Revert "feat: try re-generating snapshot [run ci]" This reverts commit d763e1f. * fix typing error * types * fix test * chore: try using [email protected] * update test * regen linux snapshot * update snapshots for darwin * re-gen linux snapshot * yarn install * update snapshots * update snapshot metadata * update snapshots due to babel deps changing slightly * make react docgen a dep * update tests * revert * snapshots again?? * revert * update * update * try change snapshot * change snap * update snap * feat: remove unnecessary ts-ignore * feat: add more test cases * feat: create CodegenActions; other minor refactors * feat: continue UI work * feat: ignore config and Cypress-related files * feat: PR feedback * update Vue component link * merge in default export work * consolidate graphql queries * other misc feedback * use network-only policy to fetch files; include cypress/ dir for code gen candidates; fix type error * add basic e2e test * fix app integration tests * refactor and fix app component and webpack dev server tests * add error state; fix unit tests [skip ci] * simplify generator show logic [skip ci] * more testing * fix types * style updates [skip ci] * fix error state [skip ci] * fix list padding [skip ci] * use slots (#25079) * add more tests; fix unit tests * fix types * fix test describe * add percy snapshots for new list * update trouble rendering banner link [skip ci] * use collapsible component * use button for component list items * fix tests * build binaries * revert changes to circle config * remove eslintignore and extra loading div [skip ci] because we know it will fail * revert changes to framework glob patterns [skip ci] Co-authored-by: Ryan Manuel <[email protected]> Co-authored-by: Lachlan Miller <[email protected]>
…create-from-react-component
|
Thanks for taking the time to open a PR!
|
astone123
changed the title
lmiller1990
approved these changes
Dec 15, 2022
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
|
@lmiller1990 the docs PR is linked in the PR checklist. It's in draft for now - have a couple more things to add to it including updated screenshots. Blog post I'm not sure about, I'll talk to the marketing about it |
lmiller1990
approved these changes
Dec 15, 2022
|
I tried the binary out on my systems (mac, linux) and it's working as expected. 🎉 |
ZachJW34
approved these changes
Dec 16, 2022
…create-from-react-component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Users working in React projects can now generate a basic Component Testing spec file from the components that exist in their project.
Note: this was reviewed in several PRs - this PR does not introduce new code.
Additional details
This feature will improve the onboarding experience for users creating Component Testing specs for the first time (or not for the first time) by reducing friction and allowing them to get a component mounted inside of a test in a matter of seconds without reading any documentation or manually creating a new spec file.
Users will still be able to create empty specs from the UI as well.
Steps to test
How has the user experience changed?
https://www.loom.com/share/c9ed4fafda0a4db49b0ac9fe047f4685
PR Tasks
cypress-documentation? Add section for create from React component cypress-documentation#4907type definitions?