Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: declare used babel dependencies #24842

Merged
merged 6 commits into from
Dec 9, 2022
Merged

fix: declare used babel dependencies #24842

merged 6 commits into from
Dec 9, 2022

Conversation

mjhenkes
Copy link
Member

User facing changelog

  • declared babel dependencies that are used, but not declared.

Additional details

Dependencies used here:

cypress/npm/webpack-preprocessor/lib/cross-origin-callback-loader.ts

Lines 3 to 4 in c4fbfe3

import { default as traverse } from '@babel/traverse'
import { default as generate } from '@babel/generator'

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@mjhenkes mjhenkes self-assigned this Nov 28, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 28, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Nov 28, 2022 •
edited
Loading


Test summary

5197 • 0 • 346 • 0 • Flakiness 9

Run details
Project cypress
Status Passed
Commit 882a301
Started Dec 9, 2022 8:12 PM
Ended Dec 9, 2022 8:27 PM
Duration 15:23 💡
OS Linux Debian -
Browser Multiple

View run in Cypress Dashboard ➡️

Flakiness

cypress-in-cypress-run-mode.cy.ts 2 Flakiness
1 Cypress In Cypress - run mode > e2e run mode spec runner header is correct
2 Cypress In Cypress - run mode > hides reporter when NO_COMMAND_LOG is set in run mode
e2e/origin/cookie_behavior.cy.ts 3 Flakiness
1 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
2 ... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
3 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
This comment includes only the first 5 flaky tests. See all 9 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

mjhenkes
mjhenkes commented Dec 9, 2022
View reviewed changes
npm/grep/cypress/e2e/unit.js
expect(parsed).to.deep.equal([
[{ tag: '@tag1', invert: false }],
[{ tag: '@tag2', invert: true }],
])
})

// would need to change the tokenizer
// TODO: would need to change the tokenizer
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hasn't changed in quite a while but it's now getting linted so i added the TODO

@mjhenkes mjhenkes merged commit 910f912 into develop Dec 9, 2022
@mjhenkes mjhenkes deleted the matth/fix/add-deps branch December 9, 2022 20:39
@cypress-bot cypress-bot bot mentioned this pull request Dec 9, 2022
Closed
flotwig added a commit that referenced this pull request Dec 12, 2022
@flotwig
fix: declare used babel dependencies (#24842)
c86f424 
* fix: declare used babel dependencies

* try this???

* unlock deps
flotwig pushed a commit that referenced this pull request Dec 13, 2022
@mjhenkes @flotwig
fix: declare used babel dependencies (#24842)
3dbe730 
* fix: declare used babel dependencies

* try this???

* unlock deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisbreiding chrisbreiding chrisbreiding approved these changes

@emilyrohrbough emilyrohrbough emilyrohrbough approved these changes

Assignees

@mjhenkes mjhenkes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dependency issue after webpack-preprocessor 5.12.2
3 participants
@mjhenkes @chrisbreiding @emilyrohrbough