Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to Vue 3.2.39 #23908

Closed
wants to merge 1 commit into from
Closed

Conversation

lmiller1990
Copy link
Contributor

@lmiller1990 lmiller1990 commented Sep 21, 2022

User facing changelog

N/A

Additional details

Vue 3.2.32 breaks us, specifically this commit: https://github.com/vuejs/core/pull/5679/files

We rely on an undefined behavior which is emitting an event after a component is unmounted, which doesn't make sense. We need to change how we handle the cloud modals.

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 21, 2022

Thanks for taking the time to open a PR!

@lmiller1990 lmiller1990 changed the title deps chore: update to Vue 3.2.39 Sep 21, 2022
@lmiller1990 lmiller1990 deleted the lmiller/bump-vue-3-deps branch December 20, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to latest Vue version in monorepo
1 participant