-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sanitize internal vite plugins #22055
Conversation
Thanks for taking the time to open a PR!
|
I see a failure on https://app.circleci.com/pipelines/github/cypress-io/cypress/38902/workflows/30f43bec-0c32-4cfd-82c3-f8fad4416773/jobs/1582942 but it looks Percy-related. I don't think we are using percy in these e2e tests at the moment, going to take a closer look at what's going on there. |
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 I am on this branch and was able to open the packages/vuetify
project in https://github.com/vuetifyjs/vuetify/tree/next in global mode without hitting the error this time. Percy CI issues can wait.
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
Vite dev-server for component testing will not crash if user has vite plugins that rely on non-empty plugins list
Additional details
Vite expects registered plugins to match a certain shape. We were pushing a null value into the plugins list if the user did not enable
CYPRESS_INTERNAL_VITE_INSPECT
or did not havevite-plugin-inspect
installed. This PR filters the list of plugins we add to exclude any null values.Also added a fallback for if the require of the plugin doesn't have a
default
property, as testing locally a node require ofvite-plugin-inspect
was returning the function.Added unit testing to
npm/vite-dev-server
. We were running the vite cypress integration tests twice on CI since their is an explicit job for running the integration tests in thecircle.yml
and the package had atest
script that pointed to the integration tests. I swapped thetest
script to only run the newly added unit tests.Steps to test
See original issue
How has the user experience changed?
na
PR Tasks
cypress-documentation
?type definitions
?