-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make ScriptError display at full height in Runner #21653
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested as described, error renders with expected height 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
User facing changelog
Corrects the height of the
ScriptError
component in Cypress 10. Not really a user facing change since this hasn't been released.Additional details
This component ended up too short as a result of changes to the surrounding elements in a previous PR. The change wasn't noticed at the time since there was not an e2e test for this state, and the component test wasn't affected by the DOM changes so it looked fine in Percy.
This PR corrects the height by changing some CSS classes, and uses the AUT header store to correctly react to wrapping in the header. It also adds a test that confirms the state does appear when the runner attempts to load file with a syntax error.
Steps to test
Run
yarn dev
to open the test runner for this branch, and visit an end-to-end spec that works. Make a syntax error in the spec that's open so that the ScriptError will appear. Example of a spec that triggers this state is this one, where the closing parenthesis is missing:Once you see the error, please resize the reporter and the window, open and close the specs list etc. The error display area should always be fully visible, never get cut off and never get too small.
How has the user experience changed?
Before this PR:
After this PR:
PR Tasks
cypress-documentation
?type definitions
?