refactor: cleanup for ported vue2 module #21062
Conversation
tgriesser
requested review from
jennifer-shehane
and removed request for
a team
|
Thanks for taking the time to open a PR!
|
tgriesser
requested review from
BlueWinds and
JessicaSachs
and removed request for
jennifer-shehane
tgriesser
changed the title
…press-io/cypress into tgriesser/cleanup/UNIFY-1253-npm-vue2 * 'tgriesser/cleanup/UNIFY-1253-npm-vue2' of github.com:cypress-io/cypress: update test truncate confusing vue loader message
| @@ -1,9 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
Are we sure we don't want to retain at least some tests over this module? I agree it makes sense not to duplicate everything (especially the examples), but deleting the entire test setup feels a bit much. This is still going to be published as a separate package on NPM that we have to maintain, and I'm not sure we have test coverage of it other than the deleted files.
There was a problem hiding this comment.
We should port some of these tests in general to system-tests. This Cypress project currently isn't even setup properly at all for the new architecture (it's still using the legacy plugin api). We're doing that as part of the other tickets for each of the dev servers
User facing changelog
n/a
Additional details
cypress.json) & we have decided all tests should be run in thesystem-testsfoldercypress-vue->cypress-vue2for the bundled files for clarity: ec2a259How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?