-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove baseUrl from root-level types for supported fields #20589
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
caf28a1
fix: update types for supported fields
estrada9166 920716c
Fix build
estrada9166 4155e85
Merge branch '10.0-release' into alejandro/fix/update-types
estrada9166 7c2549c
Update types
estrada9166 49e3884
Update cypress.d.ts
estrada9166 8a056e8
Update type
estrada9166 7186f9e
Merge branch '10.0-release' into alejandro/fix/update-types
estrada9166 480d5d9
Merge branch '10.0-release' into alejandro/fix/update-types
estrada9166 6f27ef6
Merge branch '10.0-release' into alejandro/fix/update-types
estrada9166 a065bf2
Merge branch '10.0-release' into alejandro/fix/update-types
estrada9166 08b29b1
Add invalid type
estrada9166 d0ff947
Add invalid type
estrada9166 e865bc3
Merge branch '10.0-release' into alejandro/fix/update-types
estrada9166 efe12c2
Merge branch '10.0-release' into alejandro/fix/update-types
estrada9166 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need one of these tests asserting
component.baseUrl
is not allowed? (I am not sure if these inline, string-based assertions support that)