Fix issues with cy.type #2016
Merged
Fix issues with cy.type #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -199,6 +203,11 @@ module.exports = (Commands, Cypress, cy, state, config) -> | |||
| if domEvents.mouseDown.preventedDefault or not $dom.isAttached($elToClick) | |||
| afterMouseDown($elToClick, coords) | |||
| else | |||
| if $elements.isInput(el) or $elements.isTextarea(el) or $elements.isContentEditable(el) | |||
| if $elements.isNeedSingleValueChangeInputElement(el) | |||
There was a problem hiding this comment.
cannot tell what this means from its name 🤔
There was a problem hiding this comment.
oh lord, read the comments - maybe...this...is...fine... 😳
kuceb
changed the title
This was referenced Jul 16, 2018
Closed
Closed
|
i might have found another issue when usinig Cypress.Commands.add('replace', { prevSubject: true }, (subject, value) => {
// only relyable way to replace the content without scrambling the value (adding min or max)
cy.wrap(subject).clear({ force: true });
cy.wrap(subject).clear({ force: true }).type(value);
}); |
|
@phoet could you open an issue or add your comment to one of the related issues? merged PRs are not very visible. Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this grew to a large PR fixing many cy.type issues.
fix #365
fix #420
fix #586
fix #593
fix #596
fix #651
fix #940
fix #1002
fix #1108
fix #1171
fix #1209
fix #1234
fix #1366
fix #1381
fix #1684
fix #1686
fix #1926
fix #2056
fix #2096
fix #2110
fix #2173
fix #2187
fix #2233